Change in ovirt-engine[master]: core: PerformImagesChecks no check for no disks

amureini at redhat.com amureini at redhat.com
Mon Apr 22 14:29:01 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: PerformImagesChecks no check for no disks
......................................................................


core: PerformImagesChecks no check for no disks

Removed the check for no image disks from PerfomImagesChecks: creating a
template, creating a snapshot and removing a snapshot should also work
on diskless VMs, however useless it may be.

Move VM has this check explicitly defined in its canDoAction, and is
deprecated, regardless.

After this change, there is no difference between PerformImagesChecks
and checkDiskImages, so the ltater (which was private) was removed,
and the code inlined into PerformImagesChecks.

Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 2 insertions(+), 21 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list