Change in ovirt-engine[master]: core: use local TX in AddVm flow

[rgolan at redhat.com]

Roy Golan has submitted this change and it was merged.

Change subject: core: use local TX in AddVm flow
......................................................................


core: use local TX in AddVm flow

Taking VDS calls out of TX in Add VM Pool with VMs flow so long calls to
VDSM won't exceed the TX timeout.

To understand the commands that are influenced by this concider this
call tree:

 <pre>
 AddVmPoolWithVMsCommand
  |
   -> Lock tepmlate status
  |
   -> AddVmAndAttachToPoolCommand
       |
        -> AddVMCommand
            |
             -> save static,dynamic etc.   (new TX + compensation)
            |
             -> GetImageInfo - VDSM call   (out of TX)
            |
             -> set image status           (new TX + compensation)
            |
             -> CreateSnapshot - VDSM call (out of TX)
            |
             -> update old|save new disk image (new TX + compensation)

Bug-Url: https://bugzilla.redhat.com/948282
Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
5 files changed, 85 insertions(+), 51 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>