Change in ovirt-engine[master]: core: Del ImagesHandler.isDomainWithinThresholds

amureini at redhat.com amureini at redhat.com
Sun Apr 28 08:32:13 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Del ImagesHandler.isDomainWithinThresholds
......................................................................


core: Del ImagesHandler.isDomainWithinThresholds

ImagesHandler.isDomainWithThresholds is useless method - all it does is
invoke a StorageDomainValidator, which could (and should!) be done
directly.

This patch replaces the single usage it had with a direct call to the
validator, and removes this method, along with the validate method
that's only called from it.

Change-Id: I7a0c776e9798d6128a3aac4400e1a22b3df84b56
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 1 insertion(+), 35 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0c776e9798d6128a3aac4400e1a22b3df84b56
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list