Change in ovirt-engine[master]: packaging - added check on firewall-cmd support

oschreib at redhat.com oschreib at redhat.com
Sun Apr 28 08:45:45 UTC 2013


Ofer Schreiber has submitted this change and it was merged.

Change subject: packaging - added check on firewall-cmd support
......................................................................


packaging - added check on firewall-cmd support

Added a check for --permanet option support for firewall-cmd.
If it's not supported, firewalld will not be available as
firewall manager.

Moved firewalld to global scope, the import will not fail
also if firewalld is not installed on the system.

Change-Id: I64c441c7fde548a8b2798c9f63d59962ff6e51c3
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine_firewalld.py
2 files changed, 19 insertions(+), 6 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64c441c7fde548a8b2798c9f63d59962ff6e51c3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list