Change in ovirt-engine[master]: engine: Exception handling - VDSCommandBase

mkublin at redhat.com mkublin at redhat.com
Mon Apr 29 09:07:53 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Exception handling - VDSCommandBase
......................................................................


engine: Exception handling - VDSCommandBase

The following patch will simplify exception handling in case of failure in xml rpc call.
All XmlRpcRunTimeException will be translated to network exception with error code VdcBllErrors.VDS_NETWORK_ERROR.
The XmlRpcRunTimeException - means that we failed in call , failed to parse xml and we did not get appropriate response
that we can parse, this is by definition VdcBllErrors.VDS_NETWORK_ERROR.
Now, VdcBllErrors.VDS_PROTOCOL error was removed as unused.

Change-Id: I0bd38cd75706ff7669c1ff055b951aeb864b2736
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
5 files changed, 7 insertions(+), 49 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved
  Yair Zaslavsky: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bd38cd75706ff7669c1ff055b951aeb864b2736
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list