Change in ovirt-engine[master]: gluster: Add host: Improved gluster validation [2]

sanjal at redhat.com sanjal at redhat.com
Tue Apr 30 06:58:59 UTC 2013


Shireesh Anjal has submitted this change and it was merged.

Change subject: gluster: Add host: Improved gluster validation [2]
......................................................................


gluster: Add host: Improved gluster validation [2]

Currently we don't allow to add a host if it has peers. However, if one
(or more) of those peers are already part of the cluster in engine DB,
then it means that these have been added from gluster CLI and hence the
validation should not fail in such cases.

Change-Id: I36b3b6d00a71af50ef1b006e95daebfbfe3f67f5
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/gluster/GlusterUtil.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/gluster/GlusterUtilTest.java
4 files changed, 61 insertions(+), 19 deletions(-)

Approvals:
  Shireesh Anjal: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36b3b6d00a71af50ef1b006e95daebfbfe3f67f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>



More information about the Engine-commits mailing list