Change in ovirt-engine[master]: engine: Add more validations for vnic profiles

masayag at redhat.com masayag at redhat.com
Thu Aug 8 18:34:32 UTC 2013


Moti Asayag has submitted this change and it was merged.

Change subject: engine: Add more validations for vnic profiles
......................................................................


engine: Add more validations for vnic profiles

The patch adds validation for the custom properties value
set for a vnic profile and also verifies a profile which
belongs to an external network is not set for port mirroring.

Change-Id: I2217e0d3bb6ee74f5c208964e2e06c4ecf916ebf
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java
4 files changed, 61 insertions(+), 2 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2217e0d3bb6ee74f5c208964e2e06c4ecf916ebf
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list