Change in ovirt-engine[master]: frontend: Fix for showTooltip condition in AbstractCellWithT...

tjelinek at redhat.com tjelinek at redhat.com
Tue Aug 13 10:55:24 UTC 2013


Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: Fix for showTooltip condition in AbstractCellWithTooltip
......................................................................


frontend: Fix for showTooltip condition in AbstractCellWithTooltip

Showing tooltips with the content only works (on Firefox and Chrome
at least) if the content overflows AND contains whitespaces.
If it does not contain whitespaces it will not work. The additional
condition added by this patch will fix this issue by comparing the
actual size of the column with the scrollSize (height and width)

If either of them differs, in the sense that the clientSize is smaller
then the condition is true which means it does indeed overflow.

Change-Id: I26f4942c4f24beedd6b22261f8928bc4b1af5e50
Bug-Url: https://bugzilla.redhat.com/996496
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithTooltip.java
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26f4942c4f24beedd6b22261f8928bc4b1af5e50
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list