Change in ovirt-engine[master]: core: fix task revert for ImportRepoImageCommand

amureini at redhat.com amureini at redhat.com
Wed Aug 14 11:47:13 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: fix task revert for ImportRepoImageCommand
......................................................................


core: fix task revert for ImportRepoImageCommand

ImportRepoImageCreateTaskHandler needs to define getRevertTaskType in
order to have the proper task handling in CommandBase during the task
revert process.

The compensation implementation that was previously using:

  RunVdsCommand(VDSCommandType.DeleteImageGroup, ...)

has been replaced with the more complete:

  runInternalAction(VdcActionType.RemoveDisk, ...)

which handles the entire removal of the disk (database entry included).

Change-Id: I2fea15129eb9e1b0dc1ed6d7d09d8dd63cddd5db
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
1 file changed, 5 insertions(+), 29 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17756
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fea15129eb9e1b0dc1ed6d7d09d8dd63cddd5db
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list