Change in ovirt-engine[master]: core: Remove DiskImage ctor only used in cloneOf

amureini at redhat.com amureini at redhat.com
Tue Aug 20 06:46:52 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove DiskImage ctor only used in cloneOf
......................................................................


core: Remove DiskImage ctor only used in cloneOf

Removed the ctor that isn't used anywhere except in the
clopyOf(DiskImage) method.
Removing this ctor makes the copyOf(DiskImage)  method easier to
understand, and the entire class easier to maintain.

Change-Id: Ie0e37d1ef373bede0d0f7cd374a8126f338a2383
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
1 file changed, 9 insertions(+), 17 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18127
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0e37d1ef373bede0d0f7cd374a8126f338a2383
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list