Change in ovirt-engine[master]: core: Remove DiskImage ctor only used in tests

amureini at redhat.com amureini at redhat.com
Tue Aug 20 06:46:52 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove DiskImage ctor only used in tests
......................................................................


core: Remove DiskImage ctor only used in tests

Removed the ctor that isn't used anywhere in production code.
This in fact also makes the tests easier to understand, as now the test
DiskImages instances only have the relevant field values and not all
the values demanded by this useless constructor.

Change-Id: Id7a4e16f2fd993ac2b6018cf0569830c0feeff1a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
2 files changed, 14 insertions(+), 71 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7a4e16f2fd993ac2b6018cf0569830c0feeff1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list