Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Revert findbugs fix that caused regression

masayag at redhat.com masayag at redhat.com
Mon Aug 26 12:09:35 UTC 2013


Moti Asayag has submitted this change and it was merged.

Change subject: webadmin: Revert findbugs fix that caused regression
......................................................................


webadmin: Revert findbugs fix that caused regression

A findbugs fix removed a "redundant" null check, which caused the
Setup Host Networks dialog to malfunction. There was indeed a
redundant null check, but not the one that was removed.

Bug-Url: https://bugzilla.redhat.com/975886

Change-Id: I8b19c8588168281734e76e08ce98105ae5721941
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b19c8588168281734e76e08ce98105ae5721941
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list