Change in ovirt-engine[master]: core: remove redundant null check

oourfali at redhat.com oourfali at redhat.com
Thu Dec 5 13:10:23 UTC 2013


Oved Ourfali has submitted this change and it was merged.

Change subject: core: remove redundant null check
......................................................................


core: remove redundant null check

This patch removes a redundant null check in BrandingTheme.
The getResourceBundle().getString(...) method is called. This method
doesn't return null. If the key doesn't exist an exception is thrown,
but null is never returned. Thus, the check is redundant. Removing it.

Change-Id: Iea4cda8debba202683b4048d9da5ccb86f2ca0d1
Signed-off-by: Oved Ourfali <oourfali at redhat.com>
---
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22086
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea4cda8debba202683b4048d9da5ccb86f2ca0d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>



More information about the Engine-commits mailing list