Change in ovirt-engine[master]: core: Fill and check arch when importing VM and Template

rgolan at redhat.com rgolan at redhat.com
Sun Dec 8 09:18:00 UTC 2013


Roy Golan has submitted this change and it was merged.

Change subject: core: Fill and check arch when importing VM and Template
......................................................................


core: Fill and check arch when importing VM and Template

* On importing VM and Template, its architecture must match with
  cluster architecture, otherwise an error must be displayed. It's
  being checked in the import command for each one.
* On importing OVF files, the same validation is necessary, and filling
  the architecture for VM and Template is necessary. The architecture
  is filled based on the OS architecture, otherwise the architecture
  will be undefined.
* If VM or Template has undefined architecture, it cannot be imported,
  so a error message is displayed when trying to import it.

Change-Id: I6ac6093e253225f801e216310828a7afba73f9e6
Signed-off-by: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Signed-off-by: Vitor de Lima <vitor.lima at eldorado.org.br>
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa at eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 92 insertions(+), 10 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ac6093e253225f801e216310828a7afba73f9e6
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list