Change in ovirt-hosted-engine-setup[master]: Move VM operations into a mixin for reusability

sbonazzo at redhat.com sbonazzo at redhat.com
Wed Dec 11 07:06:06 UTC 2013


Sandro Bonazzola has submitted this change and it was merged.

Change subject: Move VM operations into a mixin for reusability
......................................................................


Move VM operations into a mixin for reusability

The plugin in runvm.py has lots of useful logic for manipulating the
hosted engine VM.  This logic can be very useful to other plugins (eg.
health.py) that may want to offer the user assistance with managing the
VM.  This patch moves the VM logic into a separate class that can be
mixed in with any other plugin which may want the functionality.

Signed-off-by: Adam Litke <alitke at redhat.com>
Related-To: https://bugzilla.redhat.com/1034788
Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef
---
M src/ovirt_hosted_engine_setup/Makefile.am
A src/ovirt_hosted_engine_setup/mixins.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
3 files changed, 218 insertions(+), 185 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Adam Litke: Verified



-- 
To view, visit http://gerrit.ovirt.org/22202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list