Change in ovirt-engine[master]: engine: Remove concreteStorageType property from StorageType...

amureini at redhat.com amureini at redhat.com
Wed Dec 11 16:38:37 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Remove concreteStorageType property from StorageType enum.
......................................................................


engine: Remove concreteStorageType property from StorageType enum.

StorageType enum represents all supported types of storage,
unfortunately it also contains UNKNOWN(0) and ALL(-1) values which are
not a real storage types. In order to establish which type is real this
enum doesn't need additional state 'concreteStorageType', it can just
check the value.

Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1
Signed-off-by: Sergey Gotliv <sgotliv at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
1 file changed, 11 insertions(+), 15 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list