Change in ovirt-engine[ovirt-engine-3.3]: tools: Fixing edit action of manage-domains

iheim at redhat.com iheim at redhat.com
Thu Dec 12 09:28:02 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: tools: Fixing edit action of manage-domains
......................................................................


tools: Fixing edit action of manage-domains

Bug-Url: https://bugzilla.redhat.com/1037894

The following patches fixes the edit action of
manage-domains tool to support edit of values provided
by the "ldapServers" argument.
Prior to this fix, the change was not stored at the
proper location at the vdc_options table.
Bare in mind that if -ldapServers is not provided during
the edit action no change will be made to the entry.

Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
2 files changed, 29 insertions(+), 17 deletions(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved
  Yair Zaslavsky: Verified

Objections:
  Yair Zaslavsky: I would prefer that you didn't submit this



-- 
To view, visit http://gerrit.ovirt.org/22314
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list