Change in ovirt-engine[master]: core: Make Event immutable

amureini at redhat.com amureini at redhat.com
Thu Dec 12 14:35:29 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Make Event immutable
......................................................................


core: Make Event immutable

Removed unused setters from the Event class. Once an Event is created,
it makes no sense to modify it, and having the class immutable is a good
defensive practice for this kind of data objects.

Change-Id: I92eaad099f975d279fb1ab6a9c70112e7ea194d5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java
1 file changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22000
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92eaad099f975d279fb1ab6a9c70112e7ea194d5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list