Change in ovirt-engine[master]: webadmin: Small improvements to AddRemoveRowWidget

[lvernia at redhat.com]

Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Small improvements to AddRemoveRowWidget
......................................................................


webadmin: Small improvements to AddRemoveRowWidget

Made the following changes in AddRemoveRowWidget:

* Added an event listener to the edited model's items changed event,
  which seems to be logic common to any usage of the widget.

* Removed the setItems() call from the flush() method, which turned
  out to be a bad idea for various reasons, and instead just update
  the current items of the model.

* Changed onAdd() and onRemove() to commit changes to the model by
  default, which seems to be useful.

* Changed onAdd() and onRemove() to only be invoked when triggered by
  a button press (e.g. not during initialization of the widget), the
  semantics of which would be much more intuitive to anyone who might
  inherit from this widget.

Change-Id: I645c6984f9bcfe6f00f8b7eb07313f4d4f3d7043
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditProfileBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewProfileBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java
13 files changed, 184 insertions(+), 189 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I645c6984f9bcfe6f00f8b7eb07313f4d4f3d7043
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server