Change in ovirt-engine[master]: webadmin: Refactoring in VnicProfilesEditor

[lvernia at redhat.com]

Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Refactoring in VnicProfilesEditor
......................................................................


webadmin: Refactoring in VnicProfilesEditor

Replaced the non-standard edit() method with the standard one, that
had been previously marked as deprecated. This required introducing a
new class NetworkProfilesModel, but it's better practice (now
developers don't have to be trusted to use the "correct" edit()
method). Also took the chance to parameterize all the related
ListModel instances, as the class is now generic.

Change-Id: Id8b101f869d90d5e10636ac70e653376dc29f72d
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NetworkProfilesModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java
9 files changed, 71 insertions(+), 110 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21629
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8b101f869d90d5e10636ac70e653376dc29f72d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server