Change in ovirt-engine[master]: core: remove null check at executeReadList

mlipchuk at redhat.com mlipchuk at redhat.com
Sun Dec 15 14:46:21 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: remove null check at executeReadList
......................................................................


core: remove null check at executeReadList

I think that the null validation at executeReadList should be re examined
for the following reasons:
1) We already set the key RETURN_VALUE at createCallForRead before each
call, when creating the SimpleJdbcCall.
2) Until now executeRead called executeReadList and did not checked if
the returned list is null or not.

Change-Id: I54f25002701bcaa6e82a572b6fa5ed8ffa5e043a
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54f25002701bcaa6e82a572b6fa5ed8ffa5e043a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list