Change in ovirt-engine[master]: core: use OsInfo instead of config value

derez at redhat.com derez at redhat.com
Mon Dec 16 18:45:01 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: core: use OsInfo instead of config value
......................................................................


core: use OsInfo instead of config value

Use OsInfo query instead of VirtIoScsiUnsupportedOsList config value:
* Added isOsSupportedForVirtIoScsi method to VmValidationUtils.
* Modified DiskValidator -> isOsSupportedForVirtIoScsi accordingly.
* Removed unused ConfigValues.VirtIoScsiUnsupportedOsList.

Change-Id: Idf434c5b7907f413399890a4b2e7d9f63f2bce9a
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
5 files changed, 25 insertions(+), 28 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf434c5b7907f413399890a4b2e7d9f63f2bce9a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list