Change in ovirt-engine[master]: webadmin: Change checkbox column to radio button column

lvernia at redhat.com lvernia at redhat.com
Tue Dec 17 11:21:32 UTC 2013


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Change checkbox column to radio button column
......................................................................


webadmin: Change checkbox column to radio button column

The semantics when managing cluster networks were those of a radio
button column implemented through a checkbox column, so now the view
is changed to also look like radio buttons. This was done by extending
the capabilities of CheckboxColumn, to also function as a radio button
column when needed.

Change-Id: I6576b816c53e482b54d49877eaa04088aa9f5960
Bug-Url: https://bugzilla.redhat.com/1023722
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
2 files changed, 61 insertions(+), 44 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22060
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6576b816c53e482b54d49877eaa04088aa9f5960
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list