Change in ovirt-engine[master]: core: MoveOrCopyDiskCommand space verification

amureini at redhat.com amureini at redhat.com
Tue Dec 17 14:18:37 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: MoveOrCopyDiskCommand space verification
......................................................................


core: MoveOrCopyDiskCommand space verification

This is a part of a series of patches intended to fix storage space
allocation validation throughout the system (see bz).
Added hasSpaceForClonedDisk(s) in StorageDomainValidator.
Applied use in MoveOrCopyDiskCommand (former use is buggy).

Change-Id: I951aeb531cb7ff7aaf3f1d50fc55100b6a806059
Bug-url: https://bugzilla.redhat.com/960934
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java
5 files changed, 127 insertions(+), 32 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22447
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I951aeb531cb7ff7aaf3f1d50fc55100b6a806059
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list