Change in ovirt-engine[master]: core: Fixing NPE when group is assigned with permissions

emesika at redhat.com emesika at redhat.com
Sun Dec 22 08:57:58 UTC 2013


Eli Mesika has submitted this change and it was merged.

Change subject: core: Fixing NPE when group is assigned with permissions
......................................................................


core: Fixing NPE when group is assigned with permissions

The patch associated with Idb1a7146c29eb74f97e10043d65b5a67f1430021
introduced a regression in assigning a group permissions.
Prior to that patch the entity DbGroup did not exist, hence
the CTOR of LdapGroup that has DbGroup did not exist as well.
The memberOf initialization is fixed here for cases that the flows do not
set the memberOf attribute

Change-Id: If92ce2718a32658b4118e4e7f9334b631fa6c839
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapGroup.java
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If92ce2718a32658b4118e4e7f9334b631fa6c839
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list