Change in ovirt-engine[master]: core: remove redundant fetch of vm disks on run vm

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Dec 25 12:49:24 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: remove redundant fetch of vm disks on run vm
......................................................................


core: remove redundant fetch of vm disks on run vm

There is no need to fetch the VM disks from the DB after we start to
create stateless images on run VM as stateless flow. We fetch them in
order to update the VM which is local to the RunVmCommand instance with
the stateless images. But it is not used later on in the execute phase
of the command, and the end-action phase is invoked on a new instance of
RunVmCommand anyway.

Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/22662
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list