Change in ovirt-engine[master]: webadmin: fix findbugs warning on ProviderModel

oourfali at redhat.com oourfali at redhat.com
Mon Dec 30 13:07:27 UTC 2013


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: fix findbugs warning on ProviderModel
......................................................................


webadmin: fix findbugs warning on ProviderModel

This patch fixes a findbugs warning in ProviderModel, as we case a
variable that's known to be null.
The fix just passes null, and in order to be able to address the
ambiguity, the method name was renamed according to the use-case.

Change-Id: I94c5ff1cde5c76a89ea0c56022e306a264905066
Signed-off-by: Oved Ourfali <oourfali at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 1 insertion(+), 15 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22805
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94c5ff1cde5c76a89ea0c56022e306a264905066
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list