Change in ovirt-engine[master]: engine: Fixing RecoveryStoragePool and EventQueue

mkublin at redhat.com mkublin at redhat.com
Sun Feb 3 09:27:08 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Fixing RecoveryStoragePool and EventQueue
......................................................................


engine: Fixing RecoveryStoragePool and EventQueue

The following fix is doing the following:
1. The event trigerred by RecoveryStoragePoll will be cleaned from queue if a previous
   event was reconstruct and it finished with success
2. The event of RecoveryStoragePool will be added the first to the queue, because of it was
   triggered by user
3. Removed a code from RecoveryStoragePool which should prevent a race, the reason is no race is prevented,
   code was duplicated, the logic was duplicated, the logic should be simple and rewritted in other way

Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
2 files changed, 39 insertions(+), 36 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b58f095c69c76116f0af44b08ccaf41d1ff1fb8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list