Change in ovirt-engine[master]: Hosts from another data center displayed when...

emesika at redhat.com emesika at redhat.com
Mon Feb 4 09:37:28 UTC 2013


Eli Mesika has submitted this change and it was merged.

Change subject: Hosts from another data center displayed when...
......................................................................


Hosts from another data center displayed when...

Hosts from another data center displayed when clicked on Hosts in tree view for cluster names with a single difference

The way the ESCAPE character is used was changed between 8.4 and 9.x
The '_' character is considered as regexp '?' character in the case
ilike is used as the condition operator, therefore, we are forced to
sign it as a normal character that is part of the string
However, it seems that PG 8.4 forces us to use double ESCAPE character
for that while it will not find any matching with one ESCAPE character
and PG 9.1 is exactly the opposite , one ESCAPE character works while
double ESCAPE characters will bring no data.

The patch adds a new configuration variable PgMajorRelease that is
computed when the 0000_config.sql script is running.
The value of this variable is used to determine how to skip the special
character '_' if found in the value string.

Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99973
Signed-off-by: Eli Mesika <emesika at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=874660
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
3 files changed, 50 insertions(+), 1 deletion(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99973
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list