Change in ovirt-engine[master]: userportal: refactor in UserPortalListModel & BootSequenceMo...

tjelinek at redhat.com tjelinek at redhat.com
Wed Feb 6 11:40:43 UTC 2013


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal: refactor in UserPortalListModel & BootSequenceModel
......................................................................


userportal: refactor in UserPortalListModel & BootSequenceModel

- extract the code that set the boot from network option for a given vm
  from UserPortalListModel#RunOnce to a new private method to make it a
  little bit shorter
- extract the common code in BootSequenceModel#getHardDiskOption,
  BootSequenceModel#getNetworkOption, BootSequenceModel#getCdromOption
  to a new private method to reduce the code duplication

Change-Id: I841bedf241e82f6f89e88a66d6cd4e4ea681102f
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
2 files changed, 21 insertions(+), 30 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11736
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I841bedf241e82f6f89e88a66d6cd4e4ea681102f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list