Change in ovirt-engine[engine_3.2]: engineencryptutils: cleanup

oschreib at redhat.com oschreib at redhat.com
Wed Feb 6 14:31:10 UTC 2013


Ofer Schreiber has submitted this change and it was merged.

Change subject: engineencryptutils: cleanup
......................................................................


engineencryptutils: cleanup

Remove dead code.
Remove redundant variables.
Rework to reach somewhat similar structure between functions.
Remove the use of StringHelper.

Not that the result is good... but at least something in the right way.

Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/engineencryptutils/pom.xml
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java
2 files changed, 20 insertions(+), 114 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list