Change in ovirt-engine[master]: core: Remove VdcActionParameterBase.httpSessionId

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove VdcActionParameterBase.httpSessionId
......................................................................


core: Remove VdcActionParameterBase.httpSessionId

httpSessionId in VdcActionParameterBase is a private field that isn't
initialized in the constructor and has no set method. I.e., it is always
null.

Since it's actually a constant, there is no reason to hold it. This
patch removes the field and all its references. That refactoring, in
turn allows cleaning up login and logout flows a bit, as they have code
that only fires when this member is not null.

Change-Id: I239d13175a511291def1eb31ce55be17f376bf42
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LogoutUserCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
3 files changed, 4 insertions(+), 44 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I239d13175a511291def1eb31ce55be17f376bf42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>