Change in ovirt-engine[master]: engine: slave interfaces are being overridden

masayag at redhat.com masayag at redhat.com
Thu Feb 7 13:06:09 UTC 2013


Moti Asayag has submitted this change and it was merged.

Change subject: engine: slave interfaces are being overridden
......................................................................


engine: slave interfaces are being overridden

When the client provides a bond with its slaves, the slaves are
being reloaded from the engine, causing the information not provided
by the client to be populated by the engine's nics data.

In order to unset previously configured slave configuration, the client
need to specifically override it so the unsupported slave's configuration
will be unset, if the slave was previously configured with any of the
following properties: network name, vlan notation, boot protocol, IP address,
gateway or netmask.

An attempt to provide a slave which isn't configured properly will be blocked by
the engine with a can-do-action message.

Change-Id: I4f38bc399059ad19e93fcad0f360957636ac7045
Bug-Url: https://bugzilla.redhat.com/907240
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 44 insertions(+), 2 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f38bc399059ad19e93fcad0f360957636ac7045
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list