Change in ovirt-engine[master]: engine: Fix ValidationResult

mkolesni at redhat.com mkolesni at redhat.com
Sun Feb 10 13:54:52 UTC 2013


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Fix ValidationResult
......................................................................


engine: Fix ValidationResult

1. Changed equals not to use instanceof since the class is final.
2. Added variable replacements to the TSEHC (toString/equals/hashCode)
   methods since it's part of the object's identity.

Change-Id: I6faefd9926c241055fc4957ce3c639308ef5833f
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java
3 files changed, 24 insertions(+), 5 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11834
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6faefd9926c241055fc4957ce3c639308ef5833f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list