Change in ovirt-engine[master]: tools: engine-notifier accept special chars

dfediuck at redhat.com dfediuck at redhat.com
Tue Feb 12 16:19:49 UTC 2013


Doron Fediuck has submitted this change and it was merged.

Change subject: tools: engine-notifier accept special chars
......................................................................


tools: engine-notifier accept special chars

Due to the way configuration was loaded in the bash script
special characters would create some unwanted behaviors.

Now the configuration file is read and the variables are added
using "declare" statement
It is expected that the config file is of the form key=value

Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2
Bug-Url: https://bugzilla.redhat.com/883301
Signed-off-by: Noam Slomianko <nslomian at redhat.com>
---
M backend/manager/tools/src/main/shell/engine-notifier.sh
1 file changed, 15 insertions(+), 2 deletions(-)

Approvals:
  Doron Fediuck: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10704
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list