Change in ovirt-engine[master]: webadmin: remove redundant variable

tnisan at redhat.com tnisan at redhat.com
Thu Feb 14 13:35:27 UTC 2013


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: remove redundant variable
......................................................................


webadmin: remove redundant variable

Remove isNew variable from StorageListModel because it's not needed.
The evaluated statement storage==null is always false,
because couple of rows before that storage name and descriptions
are evaluated, and if storage was null, then NPE would be thrown there.
Thus, storage is not null and the expression is always false, and isNew
variable is not needed.

Change-Id: Ib755a8fb39bae04349ee2617d556a589ab7cfd5c
Signed-off-by: Alissa Bonas <abonas at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12063
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib755a8fb39bae04349ee2617d556a589ab7cfd5c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list