Change in ovirt-engine[master]: core: ImagesHandler.getAllStorageIdsForImageIds

amureini at redhat.com amureini at redhat.com
Sun Feb 17 14:43:54 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImagesHandler.getAllStorageIdsForImageIds
......................................................................


core: ImagesHandler.getAllStorageIdsForImageIds

Extracted a method to get all the relevant storage domains IDs from a
collection of DiskImages, and added some tests to it.

This method will be used in subsequent patches in the effort to decouple
ImagesHandler.PerformImagesChecks, but in the meanwhile it's main
benefit is the added unit test coverage.

Change-Id: If1b4d7231a03ea5a6d991609a65951fe4e279ef5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
2 files changed, 47 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12131
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1b4d7231a03ea5a6d991609a65951fe4e279ef5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list