Change in ovirt-engine[master]: core: Fix NPE in AuditLogableBaseTest

amureini at redhat.com amureini at redhat.com
Fri Feb 22 15:02:33 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix NPE in AuditLogableBaseTest
......................................................................


core: Fix NPE in AuditLogableBaseTest

AuditLogableBaseTest would print an annoying NullPointerException
stacktrace due to getVm() trying to access VmNetworkInterfaceDao in
getVm().

This patch adds a mock for that DAO (with no additional behavior, as to
not change the test's semantics) to avoid this annoying output.

Change-Id: I24940142c12e0259544f3e3cb8bc8bd8ca2c2cfa
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12265
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24940142c12e0259544f3e3cb8bc8bd8ca2c2cfa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list