Change in ovirt-engine[master]: core: fix redundant storage server conn in db

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: fix redundant storage server conn in db
......................................................................


core: fix redundant storage server conn in db

Fix several problems related to "orphan" storage server connections
entries in DB.

The redundant entries were inserted when AddStorageServerConnectionCommand
succeeded, but another command that ran after it failed. Adding a new
command that in case of failure deletes the connection entry from DB fixes the
problem.

As part of the fix, added assignment of the connection id in UI in
StorageListModel after it is created, because otherwise it
would not know which connection to delete in case of a failure.

The fix takes care of use cases of NFS, POSIX and local storage
operations originated from UI.

Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8
Bug-Url: https://bugzilla.redhat.com/815083
Signed-off-by: Alissa Bonas <abonas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
5 files changed, 44 insertions(+), 11 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea5468371514bd2c7bc043a6c5520e2864a09fe8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>