Change in ovirt-engine[master]: core: sanity check for cluster's quota

gchaplik at redhat.com gchaplik at redhat.com
Wed Feb 27 15:46:06 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: sanity check for cluster's quota
......................................................................


core: sanity check for cluster's quota

If quota mode is enforced, we should fail action in case
no quota is provided.
This bug was hidden from UI, and discovered via REST, since
there is a client validation for it.

The original bug was opened only for AddVmFromScratch,
Added this missing check also to:
*AddVm
*AddVmFromTemplate
*AddVmFromSnapshot
*AddVmTemplate

Change-Id: I0ef84ca9603a16014edaa4ddf99dfaa2f31744d4
Bug-Url: https://bugzilla.redhat.com/909749
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 49 insertions(+), 10 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12012
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ef84ca9603a16014edaa4ddf99dfaa2f31744d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list