Change in ovirt-engine[master]: core: DB fix skipped insertions to schema_version

mlipchuk at redhat.com mlipchuk at redhat.com
Mon Jan 7 14:42:54 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: DB fix skipped insertions to schema_version
......................................................................


core: DB fix skipped insertions to schema_version

When running create_db.sh scripts 03_00_0420 and beyond are executed but
not inserted to the schema_version table.
This is caused to a race since execute_comamnd is running in a loop and
creates a temporary file in each iteration.
Solution is to gather all inserts in one file and execute them at once.

Change-Id: I285434b566a17e1c1b051469b72d1470bca2109b
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/dbscripts/dbfunctions.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Eli Mesika: Verified
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I285434b566a17e1c1b051469b72d1470bca2109b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list