Change in ovirt-engine[master]: gluster: Fixed deadlock in nested command execution

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Jan 8 11:48:09 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: gluster: Fixed deadlock in nested command execution
......................................................................


gluster: Fixed deadlock in nested command execution

The CreateGlusterVolume command internally calls SetGlusterVolumeOption.
Both these try to acquire exclusive lock on the cluster, resulting in a
deadlock. To fix this, Modified GlusterCommandBase to acquire a lock on
the cluster only if it is not an internal execution.

Change-Id: Id080ad6ac3587ab9c3443cb83969783955dfb082
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
2 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Shireesh Anjal: Verified
  Omer Frenkel: Looks good to me, approved
  Yair Zaslavsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/10448
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id080ad6ac3587ab9c3443cb83969783955dfb082
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list