Change in ovirt-engine[master]: webadmin: Status label is not update on IE

gchaplik at redhat.com gchaplik at redhat.com
Wed Jan 16 12:28:00 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: Status label is not update on IE
......................................................................


webadmin: Status label is not update on IE

On dragStart we setData on the dragDropEvent.
Later we use this data as a key to the dragged object.

On dragenter, dragleave, dragover we update the status label.
We use the getData to find out the dragged element.
On firefox it works fine, but on most of the browsers drag, dragenter,
dragleave, dragover and dragend don't have access to event's data.
It is part of the DnD specification itself and firefox is the exception
here.

So, to workaround it- the dragged element key is saved as a static member
of NetworkItemPanel class.

Change-Id: Id72896117ce2b26f99607f3d34a55642fbe548bd
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java
3 files changed, 19 insertions(+), 4 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11079
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id72896117ce2b26f99607f3d34a55642fbe548bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>



More information about the Engine-commits mailing list