Change in ovirt-engine[master]: core: RemoveDiskCommand lazy getters

amureini at redhat.com amureini at redhat.com
Sun Jan 20 12:53:51 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: RemoveDiskCommand lazy getters
......................................................................


core: RemoveDiskCommand lazy getters

Extracted lazy getters for getDisk() and getDiskImage() in
RemoveDiskCommand.

This is done for two reasons:
1. To avoid ugly casts all over the code
2. To avoid a DB access in the constructor, which facilitates easier
   unit testing.

Change-Id: I5f38b27bd9456c990999660a5df0d6e4b807c207
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 40 insertions(+), 30 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11162
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f38b27bd9456c990999660a5df0d6e4b807c207
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list