Change in ovirt-engine[master]: engine: Improving export of xmls

mkublin at redhat.com mkublin at redhat.com
Mon Jan 21 07:49:15 UTC 2013


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Improving export of xmls
......................................................................


engine: Improving export of xmls

The following patch is one of the first step which is done in order to improve our
xml read/write infrastructure.
The change contains:
1. During export of xml no need to create a temp file and after that load it, the following code was removed.
2. Clean up of appropriate files
3. removing un needed classes
Main benefits, perfromance should be improved on every export xml operation (removed i/o), code should become
more clean

Change-Id: If8206580740be92cac7ffdbdc1c2f53ac0021d2e
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Formatting.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/backendcompat/XmlDocumentTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
10 files changed, 54 insertions(+), 159 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8206580740be92cac7ffdbdc1c2f53ac0021d2e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list