Change in ovirt-engine[master]: engine: Fix SHD service not displaying issue (#885592)

sanjal at redhat.com sanjal at redhat.com
Wed Jan 23 05:35:19 UTC 2013


Shireesh Anjal has submitted this change and it was merged.

Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................


engine: Fix SHD service not displaying issue (#885592)

To get the service info, the UI will not pass the volume name, in that case
engine will fetch the volume name in the database.

NFS volume name should be passed to get nfs service details, similarly
REPLICATE/DISTRIBUTED_REPLICATE volume name should be passed as an
argument to get the SHD details.

So to get volume name from database engine will do the following steps.
1. Engine will fetch NFS + REPLICATE/DISTRIBUTED_REPLICATE volume name.
2. If not found first the engine will fetch the nfs volume name and then fetch
   REPLICATE/DISTRIBUTED_REPLICATE volume name.
3. The VDS query will be called twice, one with nfs volume name
   and another with replicate volume name, finally combine the service details.

Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Bug-Url: https://bugzilla.redhat.com/885592
Signed-off-by: Dhandapani <dgopal at redhat.com>
---
M backend/manager/dbscripts/gluster_volumes_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java
5 files changed, 219 insertions(+), 32 deletions(-)

Approvals:
  Shireesh Anjal: Looks good to me, approved
  Dhandapani Gopal: Verified


--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal at redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>



More information about the Engine-commits mailing list