Change in ovirt-engine[master]: core: MoveOrCopyImageGroup - fixes and changes to revertTask...

mlipchuk at redhat.com mlipchuk at redhat.com
Wed Jan 23 17:22:34 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: MoveOrCopyImageGroup - fixes and changes to revertTasks
......................................................................


core: MoveOrCopyImageGroup - fixes and changes to revertTasks

currently the revertTasks method in MoveOrCopyImageGroupCommand issues a
RemoveImage command in order to attempt to revert to operation. The
issued RemoveImage command parameters are set with
MoveOrCopyImageGroupCommand as the parent command.

*Removes unneeded further execution of revertTasks method upon the
completion of each RemoveImage.
*In case of import vm failure, the disks will be removed during
RemoveImage endSuccesfully method.
*added execution of revert tasks in case of import vm.

Change-Id: I0f767fcfa05d48ba085910dac7a1b746601381a9
Bug-Url: https://bugzilla.redhat.com/890922
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
2 files changed, 17 insertions(+), 13 deletions(-)

Approvals:
  Maor Lipchuk: Looks good to me, approved
  Liron Aravot: Verified


--
To view, visit http://gerrit.ovirt.org/11329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f767fcfa05d48ba085910dac7a1b746601381a9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list