Change in ovirt-engine[master]: engine: Improved host life cycle

[mkublin at redhat.com]

Michael Kublin has submitted this change and it was merged.

Change subject: engine: Improved host life cycle
......................................................................


engine: Improved host life cycle

The following patch is introducing a folloing improvements:
1. By adding HostStoragePoolParametersBase class, it is possible to pass
   vds and storage pool to command and no need to perform additional query at command
   Benefit, reduced two queries at ConnectHostToStoragePoolServersCommand and at
   DisconnectHostFromStoragePoolServersCommand
2. From now DisconnectHostFromStoragePoolServersCommand running with out openning transaction,
   no need , DB is not updated so no need for global transaction.
   Benefit - less long transaction during moving host to maintainance
3. Removed canDoAction of DisconnectHostFromStoragePoolServersCommand, usually will be true, reason
   it is useless.
   Benefit - less useless code, less useless checks

Change-Id: I14b07f4568a78e4da359c1ac3bfd8417550574d7
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java
6 files changed, 71 insertions(+), 40 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11308
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14b07f4568a78e4da359c1ac3bfd8417550574d7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>