Change in ovirt-engine[master]: core: Streamline RestoreAllSnapshots.canDoAction

amureini at redhat.com amureini at redhat.com
Mon Jan 28 10:30:56 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Streamline RestoreAllSnapshots.canDoAction
......................................................................


core: Streamline RestoreAllSnapshots.canDoAction

Refactored RestoreAllSnapshostsCommand's canDoAction() to use validators
and the setActionMessageParameters() to be more readable.

Change-Id: Ic06cd91e90cbe8ec10ad3e50b98c04796222e813
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java
2 files changed, 38 insertions(+), 23 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11446
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic06cd91e90cbe8ec10ad3e50b98c04796222e813
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list