Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Jan 28 15:15:24 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: fix monitoring of SetNonOperationalVdsCommand
......................................................................


core: fix monitoring of SetNonOperationalVdsCommand

This patch resolves a bug in which an exception was thrown when a step
for an already completed and cleaned-up job is saved, when
SetNonOperationalVdsCommand is invoked and finished and then a step for
a migration it triggered is about to save.

The solution is to extract the migrations to be monitored as different
job, which reflects the process better on this scenario as the host become
non-oprational independently of the status of the triggered migrations.

Change-Id: I06b08108b1c75fe00b3f4dc6336c61a5e8c95d85
Bug-Url: https://bugzilla.redhat.com/888199
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
4 files changed, 20 insertions(+), 4 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified
  Moti Asayag: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/11370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06b08108b1c75fe00b3f4dc6336c61a5e8c95d85
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list